Add User Tier context to Notification Builder #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykazakov
requested review from
MatousJobanek,
xcoulon,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 78.46% 78.54% +0.08%
==========================================
Files 49 49
Lines 2015 2023 +8
==========================================
+ Hits 1581 1589 +8
Misses 376 376
Partials 58 58
|
|
MatousJobanek
approved these changes
Aug 22, 2024
| if userTier.Spec.DeactivationTimeoutDays > 0 { | ||
| n.Spec.Context["DeactivationTimeoutDays"] = strconv.Itoa(userTier.Spec.DeactivationTimeoutDays) | ||
| } else { | ||
| n.Spec.Context["DeactivationTimeoutDays"] = "(unlimited)" |
metlos
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can use the deactivation timeout days in the user-provisioned email templates from the corresponding user tier.
Part of https://issues.redhat.com/browse/SANDBOX-741