Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the provisioning configuration in the CachedToolchainCluster #364

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Feb 29, 2024

Because the provisioning decisions and toolchain cluster configuration are done using the combination of ToolchainConfig and CachedToolchainCluster objects, this adds the provisioning configuration (loaded from SpaceProvisionerConfig objects) to the CachedToolchainCluster.

Doing it this way, we don't have to modify much of the logic elsewhere (mainly in the tests) - we just move the configuration done with ToolchainConfig to configuration done with CachedToolchainCluster. These two things usually coincide in the codebase so the change is easy.

Note that we keep the default memory usage threshold in the ToolchainConfig because there is no place for it in the SpaceProvisionerConfig "framework". We can think about dropping it in some future PR.

Note that this is WIP. There still some test failures in the e2e tests and therefore some debugging log statements sprinkled here and there in this code, too.

JIRA issue: https://issues.redhat.com/browse/KSPACE-46

Related PRs:
host-operator: codeready-toolchain/host-operator#977
toolchain-e2e: codeready-toolchain/toolchain-e2e#905

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #364 (6644e97) into master (b32711b) will decrease coverage by 1.12%.
The diff coverage is 45.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   76.42%   75.31%   -1.12%     
==========================================
  Files          43       43              
  Lines        1998     2058      +60     
==========================================
+ Hits         1527     1550      +23     
- Misses        424      456      +32     
- Partials       47       52       +5     
Files Coverage Δ
...rs/toolchaincluster/toolchaincluster_controller.go 58.82% <0.00%> (-2.41%) ⬇️
pkg/cluster/cache.go 82.35% <0.00%> (-17.65%) ⬇️
pkg/cluster/service.go 76.77% <59.61%> (-7.47%) ⬇️

@metlos
Copy link
Contributor Author

metlos commented Mar 14, 2024

Closing in favor of codeready-toolchain/host-operator#991 and associated PRs.

@metlos metlos closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant