Include the provisioning configuration in the CachedToolchainCluster #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the provisioning decisions and toolchain cluster configuration are done using the combination of
ToolchainConfig
andCachedToolchainCluster
objects, this adds the provisioning configuration (loaded fromSpaceProvisionerConfig
objects) to theCachedToolchainCluster
.Doing it this way, we don't have to modify much of the logic elsewhere (mainly in the tests) - we just move the configuration done with
ToolchainConfig
to configuration done withCachedToolchainCluster
. These two things usually coincide in the codebase so the change is easy.Note that we keep the default memory usage threshold in the
ToolchainConfig
because there is no place for it in theSpaceProvisionerConfig
"framework". We can think about dropping it in some future PR.Note that this is WIP. There still some test failures in the e2e tests and therefore some debugging log statements sprinkled here and there in this code, too.
JIRA issue: https://issues.redhat.com/browse/KSPACE-46
Related PRs:
host-operator: codeready-toolchain/host-operator#977
toolchain-e2e: codeready-toolchain/toolchain-e2e#905