Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-192: Introduce a make command for pre-requisite of verify-replace script #465

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Sep 24, 2024

Introduce a make command for pre-requisite of verify-replace script

Related PRs:
Toolchain-common - codeready-toolchain/toolchain-common#429
Host Operator - codeready-toolchain/host-operator#1091
Member Operator - codeready-toolchain/member-operator#599
Toolchain-e2e - codeready-toolchain/toolchain-e2e#1049
Ksctl - kubesaw/ksctl#81

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@283ead3). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #465   +/-   ##
=========================================
  Coverage          ?   81.89%           
=========================================
  Files             ?       42           
  Lines             ?     2707           
  Branches          ?        0           
=========================================
  Hits              ?     2217           
  Misses            ?      404           
  Partials          ?       86           
Flag Coverage Δ
unittests 81.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@fbm3307 fbm3307 merged commit 4e4213a into codeready-toolchain:master Sep 30, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants