silence member config logs when there's no error #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member-operator was spamming this message in its logs, but there was no `err` field set. Check that an error actually exists before logging it. Signed-off-by: Andy Sadler <[email protected]>
sadlerap
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
filariow
approved these changes
Aug 1, 2024
xcoulon
approved these changes
Aug 1, 2024
|
nice catch! |
rajivnathan
approved these changes
Aug 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 31 31
Lines 2704 2704
=======================================
Hits 2253 2253
Misses 304 304
Partials 147 147 |
alexeykazakov
approved these changes
Aug 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, rajivnathan, sadlerap, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexeykazakov
merged commit ba21e2f
into
codeready-toolchain:master
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member-operator was spamming this message in its logs, but there was no
errfield set. Check that an error actually exists before logging it.