Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANDBOX-682 add suffix in resource name for role and rolebinding #585

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

ranakan19
Copy link
Contributor

fix wrt : https://issues.redhat.com/browse/SANDBOX-682

To-Do: Will clean up labels as well - Seems unlikely to be fixed soon from console but waiting for response on thread

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.22%. Comparing base (1b370af) to head (099c286).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   83.19%   83.22%   +0.02%     
==========================================
  Files          30       30              
  Lines        2684     2688       +4     
==========================================
+ Hits         2233     2237       +4     
  Misses        304      304              
  Partials      147      147              
Files Coverage Δ
controllers/useraccount/console_usersettings.go 100.00% <100.00%> (ø)
controllers/useraccount/useraccount_controller.go 84.13% <50.00%> (ø)

Copy link

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan, ranakan19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rajivnathan,ranakan19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ranakan19 ranakan19 merged commit 392066d into codeready-toolchain:master Jul 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants