-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerated from API - made UserSignup.Spec.IdentityClaims required #973
Conversation
…erator into SANDBOX-504-host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the CRD yaml it looks like only these are required.
required:
- email
- preferredUsername
- sub
probably because the others are marked as optional https://github.com/codeready-toolchain/api/blob/1e69b9614bd81720b4de6d405f5438c3331f4182/api/v1alpha1/usersignup_types.go#L191-L201
I guess you need to remove the +optional
from the individual fields within identityClaims
to make them all required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR is based on some outdated commit.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, mfrancisc, rajivnathan, ranakan19, sbryzak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 83.62% 83.64% +0.01%
==========================================
Files 55 55
Lines 6243 6243
==========================================
+ Hits 5221 5222 +1
+ Misses 837 836 -1
Partials 185 185 |
API PR: codeready-toolchain/api#400