Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSPACE-20: Drop the distinction between host & member ToolchainClusters #971

Merged
merged 11 commits into from
Mar 13, 2024

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Feb 19, 2024

This is related to Drop the distinction between host & member ToolchainClusters
Related PRs:
ToolchainCommon- codeready-toolchain/toolchain-common#359
Member-Operator - codeready-toolchain/member-operator#531
Registration-Service - codeready-toolchain/registration-service#402
Toolchain-e2e - codeready-toolchain/toolchain-e2e#893
Sandbox-sre - https://github.com/codeready-toolchain/sandbox-sre/pull/1524

@fbm3307
Copy link
Contributor Author

fbm3307 commented Feb 20, 2024

/test e2e

main.go Outdated Show resolved Hide resolved
@fbm3307
Copy link
Contributor Author

fbm3307 commented Mar 5, 2024

/test e2e

@fbm3307
Copy link
Contributor Author

fbm3307 commented Mar 5, 2024

/test e2e

@fbm3307
Copy link
Contributor Author

fbm3307 commented Mar 7, 2024

/test e2e

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.8% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #971 (5b13735) into master (a056f05) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   84.75%   84.75%           
=======================================
  Files          55       55           
  Lines        5039     5039           
=======================================
  Hits         4271     4271           
  Misses        584      584           
  Partials      184      184           

@fbm3307 fbm3307 merged commit f27b2b9 into codeready-toolchain:master Mar 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants