Skip to content

Commit

Permalink
Fixed unclickable sequences (#440)
Browse files Browse the repository at this point in the history
* Fixed unclickable sequences

* Fixed sending auth code

* Renamed the default subject

---------

Co-authored-by: Rajat Saxena <[email protected]>
  • Loading branch information
ravirajput10 and Rajat Saxena authored Oct 16, 2024
1 parent ce88afe commit a1dbadf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
5 changes: 4 additions & 1 deletion apps/web/components/admin/mails/sequences-list.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ const SequencesList = ({
(broadcast.emails[0].subject === " "
? "--"
: broadcast.emails[0].subject)}
{type === "sequence" && broadcast.title}
{type === "sequence" &&
(broadcast.title === " "
? "Untitled Sequence"
: broadcast.title)}
</Link>
</td>
<td align="right">
Expand Down
3 changes: 2 additions & 1 deletion apps/web/config/strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ export const internal = {
invalid_cloud_storage_settings: "Cloud storage settings are invalid",
domain_not_specified: "Domain is not specified",
default_group_name: "First section",
default_email_broadcast_subject: "New broadcast",
default_email_broadcast_subject: "Untitled broadcast",
default_email_sequence_subject: "First email",
default_email_sequence_name: "Untitled Sequence",
default_email_content:
"<p>Replace this with actual content.</p>\n<p>You can use <b>HTML</b>.</p>\n<p>We also support <a href='https://shopify.github.io/liquid/'>Liquid</a>.</p>\n<br>\n<p>Our mailing address is:</p>\n<p>{{ address }}</p>\n<a href=\"{{ unsubscribe_link}}\">Unsubscribe</a>",
};
2 changes: 1 addition & 1 deletion apps/web/graphql/mails/logic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export async function createSequence(
domain: ctx.subdomain._id,
type,
status: Constants.sequenceStatus[0],
title: " ",
title: internal.default_email_sequence_name,
creatorId: ctx.user.userId,
emails: [
{
Expand Down

0 comments on commit a1dbadf

Please sign in to comment.