Cleanup from #23 #24

marevol · 2024-04-15T09:22:41Z

The old value was likely a copy-paste error.

QCad doesn't display any dimensions where it's set.

In principle there's an algebraic relationship between the DXF line width value and line thickness in millimeters, and everything except AutoCAD accepts any value from the range, but AutoCAD ignores all values except a few chosen ones.

This forced API consumers to implement a lot of useless empty functions for no good reason.

These are all in our default implementation of DRW_Interface, which ignores everything it receives, so it's OK.

This caused a double free when deallocating DRW_Hatch.

It's more trouble than it's worth when supporting Windows. Instead, require the caller to always use the appropriate overload of std::[io]fstream constructor (possibly the wchar_t* one).

This makes polylines readable in AutoCAD again.

According to documentation $TDCREATE has code 40 and contains "Local date/time of drawing creation (see “Special Handling of Date/Time Variables”)".

When saving in the AC1006 format, several DIMSTYLE groups were erroneously omitted.

Some standards mandate the default layer to be unused.

Before, the layer was hardcoded to "0" in the writer.

Found via codespell and grep

Found via `codespell`

Having a user-specified assignment operator but default copy-constructor violates rule of 2/3/5/0. Found by clazy.

getExtrusion and getName was missing const qualifiers.

Dimension entities support DXF codes 210, 220, 230 and and DRW_Dimension already had a extPoint member, but the tags were never used when parsing.

Try to avoid having to deep copy unless really required...

Found by clang-tidy.

whitequark and others added 30 commits December 22, 2021 16:54

Add improved CMake buildsystem.

f12a4e6

Delete all allocated items in destructors.

42be927

Read and write knot weights in DRW_Spline.

518812a

Add forgotten initialization for DRW_Dimension::length.

6eac1d4

Set $DIMSCALE default value to 1.0.

2cc441a

The old value was likely a copy-paste error.

Don't write $DIMTXSTY (handle of referenced STYLE) by default.

3b703d0

QCad doesn't display any dimensions where it's set.

Adjust DRW_Dimstyle defaults to match DRW_Header::write.

a1e4ea0

Initialize DRW dimension type in dimension subclass constructors.

53da7e8

Add DRW_Entity::setWidthMm.

b3951a4

In principle there's an algebraic relationship between the DXF line width value and line thickness in millimeters, and everything except AutoCAD accepts any value from the range, but AutoCAD ignores all values except a few chosen ones.

Don't use pure virtual functions in DRW_Interface.

a39aeda

This forced API consumers to implement a lot of useless empty functions for no good reason.

Fix H/V align reading for MTEXT.

d369fc3

Remove unused DRW_Interface::setBlock.

3ac5f50

Silence -Wunused-parameter warnings.

fd8d324

These are all in our default implementation of DRW_Interface, which ignores everything it receives, so it's OK.

Add DRW_Dimension::{has,get,set}ActualMeasurement.

65bfb6c

Don't add spline control points twice.

7976446

This caused a double free when deallocating DRW_Hatch.

Remove dwgR::testReader().

e5bdcab

Implement variants of read/write functions that take std::[io]stream*.

e57da1b

Remove the fileName field from dwgR/dxfRW.

9e32c4b

It's more trouble than it's worth when supporting Windows. Instead, require the caller to always use the appropriate overload of std::[io]fstream constructor (possibly the wchar_t* one).

In POLYLINE, use vertex type that matches the polyline type.

fc43586

This makes polylines readable in AutoCAD again.

Fix type conversion warnings.

b244923

Fix GCC warning -Wmisleading-indentation.

27d1c60

Added more codes for colors supported by DXF.

0311944

Add support for $TDCREATE.

096ad4f

According to documentation $TDCREATE has code 40 and contains "Local date/time of drawing creation (see “Special Handling of Date/Time Variables”)".

Fix opening files saved as DXF R10 in AutoCAD.

0e353ed

When saving in the AC1006 format, several DIMSTYLE groups were erroneously omitted.

Up to DXF R12, the default layer "0" may be left undefined.

e80a9db

Some standards mandate the default layer to be unused.

Use DRW_Block::layer when writing blocks.

57cc07c

Before, the layer was hardcoded to "0" in the writer.

Misc typos: length

28be97e

Found via codespell and grep

Misc. source typos: compressed

3efc5e7

Found via `codespell`

Misc. typos

ab17517

DRW_Coord: Simplify constructor/assignment.

126d47e

Having a user-specified assignment operator but default copy-constructor violates rule of 2/3/5/0. Found by clazy.

johreh and others added 14 commits December 22, 2021 16:54

Add const-qualifiers to DRW_Dimension getters

f236550

getExtrusion and getName was missing const qualifiers.

Read extrusion tags for dimension entities

465ad9d

Dimension entities support DXF codes 210, 220, 230 and and DRW_Dimension already had a extPoint member, but the tags were never used when parsing.

Clean up looping, basically removing all counted loops.

802dbf6

Remove duplicated size fields

9ac2954

Default values

6625326

Fix typos

f9d7793

Improve construction (regular, copy, and move) and assignment.

d9f5393

Try to avoid having to deep copy unless really required...

Simplify loop to appease clang-tidy

5860b68

Clang-tidy

5e056d0

Fix memory leak.

60ba5c2

Found by clang-tidy.

DRY and clang-tidy fixes

e9a4e9a

clang-tidy

3a24406

clang-tidy fixits with small human fixups

58cdb66

Fix typo.

7360e19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup from #23 #24

Cleanup from #23 #24

marevol commented Apr 15, 2024

Cleanup from #23 #24

Are you sure you want to change the base?

Cleanup from #23 #24

Conversation

marevol commented Apr 15, 2024