Skip to content

Commit

Permalink
Disable J2ObjC testing
Browse files Browse the repository at this point in the history
- test require MacOS and external software J2ObjC
- J2ObjC support max JDK 11
- if needed we should fix test to be OS independent
- it is also disabled on GitHub build
  • Loading branch information
slawekjaranowski committed Nov 30, 2023
1 parent b941e70 commit 57598f5
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 26 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ jobs:
jdk-matrix: '["11", "17", "21"]'
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica", "corretto"]'
os-matrix: '["ubuntu-latest","windows-latest", "macOS-latest"]'
maven_args: 'verify javadoc:javadoc -e -B -V -fae -Pno-tests-if-not-on-osx'
maven_args: 'verify javadoc:javadoc -e -B -V -fae'

4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ This component is an Compilation API used by Apache Maven Compiler plugin on the
Please refer to [documentation](https://errorprone.info/docs/installation#maven)

Or the project [it test](plexus-compiler-its/src/main/it/error-prone-compiler/pom.xml)

### J2ObjC OSX

To compile this project on OSX, you need to have J2ObjC installed: [J2ObjC Requirements](https://developers.google.com/j2objc#requirements).
36 changes: 15 additions & 21 deletions plexus-compilers/plexus-compiler-j2objc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,25 +34,19 @@
</dependency>
</dependencies>

<profiles>
<profile>
<id>no-tests-if-not-on-osx</id>
<activation>
<os>
<family>!mac</family>
</os>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<skipTests>true</skipTests>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<!-- test require MacOS and external software J2ObjC -->
<!-- J2ObjC support max JDK 11 -->
<!-- if needed we should fix test to be OS independent -->
<skipTests>true</skipTests>
</configuration>
</plugin>
</plugins>
</build>

</project>

0 comments on commit 57598f5

Please sign in to comment.