FYST-1122 Part 2: Update statefile tax year to 2024 #4994
Conversation
|
Heroku app: https://gyr-review-app-4994-6141345ac37e.herokuapp.com/ |
arinchoi03
changed the title
|
at fbc72ad all specs were passing ✨ |
| @@ -18,6 +18,8 @@ def document | |||
|
|
|||
| def determine_default_schema_version_by_tax_year | |||
| case @submission.tax_return&.year || @submission.data_source&.tax_return_year | |||
| when 2024 # TODO: update with 2024 schema when available | |||
| "2023v5.0" | |||
There was a problem hiding this comment.
not sure where we can get this
| @@ -19,7 +19,7 @@ | |||
| # | |||
| FactoryBot.define do | |||
| factory :az322_contribution do | |||
| date_of_contribution_year { "2023" } | |||
There was a problem hiding this comment.
update year dynamically using the rails config here
| @@ -147,60 +147,60 @@ | |||
| state_file_az_intake: intake, | |||
| charity_code: "22345", | |||
| charity_name: "Heartland", | |||
| date_of_contribution: Date.parse("August 22 2023") | |||
There was a problem hiding this comment.
dynamically set the year
| allow(Rails.configuration).to receive(:statefile_current_tax_year).and_return 2024 | ||
| stub_const('DateAccessible::TAX_YEAR', Date.new(2024)) | ||
| end | ||
|
|
There was a problem hiding this comment.
this was the "fix" i was implementing to get the az feature specs to pass, which didn't work, so taking it out in this PR
There was a problem hiding this comment.
this file was added in the previous PR (that this branch is based off on)
| @@ -535,7 +535,7 @@ | |||
| context "looking for CTC matches" do | |||
| let(:display_type) { Intake::CtcIntake } | |||
|
|
|||
| context "with a product year of 2023" do | |||
There was a problem hiding this comment.
should put these back
| @@ -932,7 +932,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "when born on/after Jan 2, 1958 for tax year 2023" do | |||
There was a problem hiding this comment.
maybe need to revisit if I need to make this dynamic
| @@ -11,7 +11,7 @@ def step_through_eligibility_screener(us_state:) | |||
| choose "state_file_ny_eligibility_out_of_state_income_form_eligibility_part_year_nyc_resident_no" | |||
| click_on "Continue" | |||
|
|
|||
| expect(page).to have_text "In 2023, did you contribute to a 529 college savings account, or did you withdraw funds from a 529 account and use them for non-qualified expenses?" | |||
There was a problem hiding this comment.
update to using config here
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
Rails.configurationHow to test?
Screenshots (for visual changes)