Add in lines 15 and 16 to MD Form 502 #4980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-4980-16c76781e3ce.herokuapp.com/ |
anisharamnani
commented
Nov 14, 2024
| @@ -361,12 +376,12 @@ def calculate_deduction_method | |||
| s_mfs_d: { | |||
| 12000 => 1_800, | |||
| 17999 => ->(x) { x * 0.15 }, | |||
| 18000 => 2_700, | |||
| Float::INFINITY => 2_700, | |||
There was a problem hiding this comment.
@jenny-heath helped sort out there was a bug here where its supposed to be "$18,000 or over" and so the band is changed in this line. Here is the original ticket for reference.
anisharamnani
commented
Nov 14, 2024
| describe "#calculate_line_17" do | ||
| context "when method is standard" do | ||
| [ | ||
| [["single", "married_filing_separately", "dependent"], [ | ||
| [12_000, 1_800], | ||
| [17_999, 17_999 * 0.15], | ||
| [18_000, 2_700], | ||
| [18_001, 2_700], |
There was a problem hiding this comment.
changed the tests to expose the above mentioned bug.
jenny-heath
reviewed
Nov 14, 2024
| @@ -440,5 +439,21 @@ | |||
| expect(pdf_fields["Enter 13"].to_i).to eq 0 | |||
| end | |||
| end | |||
|
|
|||
| describe "Line 15" do | |||
There was a problem hiding this comment.
minor thing but there's a section above context "subtractions" do that you could move these blocks into
…fying_dependent_care_expenses Co-authored-by: Anisha Ramnani <[email protected]>
Co-authored-by: Anisha Ramnani <[email protected]>
…sOrLimitAmt to nick.xml Co-authored-by: Anisha Ramnani <[email protected]>
Co-authored-by: Anisha Ramnani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/ABCD-123](https://codeforamerica.atlassian.net/browse/FYST-655
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
Lines 15 and 16 for MD Form 502 were added. Lines 9, 10a, and 11 were stubbed.
How to test?