667 new service fields #676
Conversation
anselmbradford
force-pushed
the
667-new-service-fields
branch
from
f39629f
to
cafac1d
Compare
|
Fixes #667 |
|
Will review this later, but wanted to ask if the following additional service fields would be part of this PR:
The example location has all of these service attributes for the "Passport Photos" service. Remember to test against values returned by the API: |
|
I'd say wrap this one up and put those additional fields in another two PRs. Hours for instance can go into #671. |
|
@monfresh How's this one look? |
| it 'includes defunct status notice' do | ||
| visit('/locations/fake-org/location-with-no-phone') | ||
| element = '.services-box .status' | ||
| expect(find(element)).to have_content('service is no longer operating') |
There was a problem hiding this comment.
It's better to point to the localization instead of hardcoding the string.
expect(find(element)).to have_content(I18n.t('service_fields.status_defunct'))Also, I would add another test for the inactive scenario.
|
@monfresh Edit added! |
|
Thanks. I think it's good to rebase and merge. |
anselmbradford
force-pushed
the
667-new-service-fields
branch
12 times, most recently
from
4051366
to
c1a1d17
Compare
anselmbradford
force-pushed
the
667-new-service-fields
branch
2 times, most recently
from
6275427
to
e9b00b4
Compare
anselmbradford
force-pushed
the
667-new-service-fields
branch
from
e9b00b4
to
7c6d55b
Compare
anselmbradford
force-pushed
the
667-new-service-fields
branch
2 times, most recently
from
2bac7bb
to
d657ad7
Compare
anselmbradford
force-pushed
the
667-new-service-fields
branch
from
d657ad7
to
0e8ddcb
Compare
anselmbradford
force-pushed
the
667-new-service-fields
branch
from
0e8ddcb
to
4c43e7d
Compare
anselmbradford
force-pushed
the
667-new-service-fields
branch
from
4c43e7d
to
501e721
Compare
- In order to organize the location details spec better, this commit moves the location services tests to their own spec file. - Orders service tests to fit the order shown in the detail view (with the exception of the hours, which will be handled separately in #671) - Updates service_areas service partial name to be in the format field name prefixed by `service_`, which follows the format of the other partials. The file was named `service_areas`, which implies the field is `areas`, when in fact, it is `service_areas`. - Removes optional requirement from `how_to_apply` service field. - Edits `name` and adds `alternate_name` service field and tests. Removes optional check for the required `name` field. - Adds test for service description field and updates specificity of description test. - Makes location description test check the description selector contents as opposed to the whole page, since the checked content “Lorem Ipsum” appears in the service description fields as well. - Adds `email` service field and test. - Renames `urls` service field to `website`, since a service now only has one website. Also adds a test. - Adds a container and styles for the parent element around `website` and `email` service fields. -Adds `accepted_payments` service field, locale, and test. -Adds `required_documents` service field, locale, and test. - Adds `status` service field and test. - Renames name partial container and CSS from `title` to `name-box`.
anselmbradford
force-pushed
the
667-new-service-fields
branch
from
501e721
to
52df0b7
Compare
|
@monfresh In https://ohana-api-test.herokuapp.com/api/locations/example-location the |
|
That wasn't intentional. It's been fixed, but note that sample.txt is no longer the canonical source of the data since it will be removed once the CSV-based script is written. https://github.com/codeforamerica/ohana-api/blob/master/CONTRIBUTING.md#updating-the-sample-data |
@monfresh Ready for review and merge. Thanks! I moved the status visibility part to #675 so that the new fields can be added independent of that feature.