[WIP] updated docs and worker events #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavertMik
commented
Mar 3, 2020
lib/workers.js
Outdated
| res(true); | ||
| }, 'bootstrapAll'); | ||
| })); | ||
| event.dispatcher.emit(event.workers.before); |
There was a problem hiding this comment.
this way we can attach async hooks before workers were initialized
There was a problem hiding this comment.
@peterngtr this way we will be able to integrate ReportPortal with Codecept for parallel runs in worker.
See my PR reportportal/agent-js-codecept#3
There was a problem hiding this comment.
that's awesome 👏 @DavertMik
DavertMik
commented
Mar 3, 2020
docs/parallel.md
Outdated
| } | ||
| } | ||
| ``` | ||
| workers.on(event.all.result, (status, completed, workerStats) => { |
There was a problem hiding this comment.
@koushikmohan1996 I have really no idea what to write here in the docs
Can you help me? What are those objects and how to use them? :)
Maybe we can simplify API to it would be bit more clear?
There was a problem hiding this comment.
Ok I will write the docs
…make it available in workers.
…file to make it available in workers." This reverts commit 6dd2b8a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP PR which adds the following:
workers.beforeandworkers.aftereventsbyfunction to accept number of workers to splitTODO:
event.all.resultfor a master process. This should be more documented/clarified on how to use it to retrieve errorsApplicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)