Upgrade to react-map-gl@7 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some component props changed Popup positioning is odd, won't flip around an offset.
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joshreisner
reviewed
Feb 25, 2024
| maxChunks: 1, | ||
| }), | ||
| ], | ||
| }); |
joshreisner
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
great work, thank you @gkovats ! looks like the bundle size dropped a little too. looks like it's down to 1.36 MiB (from 1.45 MiB)
|
good observation about the popup positions, but nbd. i'm confident we'll fix it in time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #306 : Upgrade
react-map-glSome component props changed. Updated according to docs:
https://visgl.github.io/react-map-gl/docs/api-reference/map
webpack.mix.jsfile to force 1 output js / no code splittingtop, it's close to original, but when flipped to below, it drops offset distance from marker point.
They only have so many props, tried them all, this was as far as I got. Seems usable, but irksome.