Skip to content

Commit

Permalink
[ELI5] change sign in to create account (bluesky-social#6931)
Browse files Browse the repository at this point in the history 
* change sign in to create account

* alf buttons on native bottom bar

* manually edit .po file
  • Loading branch information
@mozzius
mozzius authored Jan 8, 2025
1 parent 7c8c78b commit a0393fc
Show file tree
Hide file tree
Showing 35 changed files with 65 additions and 63 deletions.
2 changes: 1 addition & 1 deletion src/locale/locales/an/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6417,7 +6417,7 @@ msgstr "Salir?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Crear cuenta"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ast/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6861,7 +6861,7 @@ msgstr "¿Quies zarrar la sesión?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Rexistrase"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ca/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8301,7 +8301,7 @@ msgstr "Tancar la sessió?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Registra't"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/de/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7634,7 +7634,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Registrieren"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/el/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6430,7 +6430,7 @@ msgstr "Αποσύνδεση;"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Εγγραφή"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/en-GB/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6861,7 +6861,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr ""

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/en/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6861,7 +6861,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr ""

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/es/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7569,7 +7569,7 @@ msgstr "¿Cerrar sesión?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Crear cuenta"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/fi/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6282,7 +6282,7 @@ msgstr "Kirjaudutaanko ulos?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Rekisteröidy"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/fr/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6282,7 +6282,7 @@ msgstr "Se déconnecter ?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "S’inscrire"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ga/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6860,7 +6860,7 @@ msgstr "Logáil amach?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Cláraigh"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/gl/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7574,7 +7574,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Crear conta"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/hi/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7248,7 +7248,7 @@ msgstr "साइन आउट करें?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "साइन अप करें"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/hu/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6725,7 +6725,7 @@ msgstr "Kijelentkezés"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Regisztráció"

#~ msgid "Sign up or sign in to join the conversation"
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/id/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7717,7 +7717,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Daftar"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/it/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6288,7 +6288,7 @@ msgstr "Uscire?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Iscriviti"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ja/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6282,7 +6282,7 @@ msgstr "サインアウトしますか？"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "サインアップ"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/km/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6865,7 +6865,7 @@ msgstr "ចេញ?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "ចុះឈ្មោះ"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ko/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6282,7 +6282,7 @@ msgstr "로그아웃하시겠습니까?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "가입하기"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ne/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7252,7 +7252,7 @@ msgstr "साइन आउट गर्नुहोस्?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "साइन अप गर्नुहोस्"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/nl/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6417,7 +6417,7 @@ msgstr "Afmelden?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Registreren"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/pl/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6433,7 +6433,7 @@ msgstr "Wylogować się?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Zarejestruj się"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/pt-BR/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7709,7 +7709,7 @@ msgstr "Sair?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Inscrever-se"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ro/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6865,7 +6865,7 @@ msgstr "Deconectează-te?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Înscrie-te"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/ru/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6314,7 +6314,7 @@ msgstr "Выйти?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Регистрация"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/th/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7704,7 +7704,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "สมัครสมาชิก"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/tr/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8147,7 +8147,7 @@ msgstr "Çıkış yap?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Kaydol"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/uk/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7717,7 +7717,7 @@ msgstr ""
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Реєстрація"

#: src/view/shell/NavSignupCard.tsx:47
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/vi/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6409,7 +6409,7 @@ msgstr "Đăng xuất?"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "Đăng ký"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/zh-CN/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6287,7 +6287,7 @@ msgstr "确定要登出吗？"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "注册"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/zh-HK/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6289,7 +6289,7 @@ msgstr "係咪要登出？"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "註冊"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
2 changes: 1 addition & 1 deletion src/locale/locales/zh-TW/messages.po
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6287,7 +6287,7 @@ msgstr "確定要登出嗎？"
#: src/view/shell/bottom-bar/BottomBarWeb.tsx:205
#: src/view/shell/NavSignupCard.tsx:47
#: src/view/shell/NavSignupCard.tsx:52
msgid "Sign up"
msgid "Create account"
msgstr "註冊"

#: src/components/moderation/ScreenHider.tsx:91
Expand Down
4 changes: 2 additions & 2 deletions src/view/shell/NavSignupCard.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ let NavSignupCard = ({}: {}): React.ReactNode => {
<View style={[a.flex_row, a.flex_wrap, a.gap_sm, a.pt_md]}>
<Button
onPress={showCreateAccount}
label={_(msg`Sign up`)}
label={_(msg`Create account`)}
size="small"
variant="solid"
color="primary">
<ButtonText>
<Trans>Sign up</Trans>
<Trans>Create account</Trans>
</ButtonText>
</Button>
<Button
Expand Down
30 changes: 15 additions & 15 deletions src/view/shell/bottom-bar/BottomBar.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {usePalette} from '#/lib/hooks/usePalette'
import {clamp} from '#/lib/numbers'
import {getTabState, TabState} from '#/lib/routes/helpers'
import {useGate} from '#/lib/statsig/statsig'
import {s} from '#/lib/styles'
import {emitSoftReset} from '#/state/events'
import {useHomeBadge} from '#/state/home-badge'
import {useUnreadMessageCount} from '#/state/queries/messages/list-conversations'
Expand All @@ -26,12 +25,12 @@ import {useSession} from '#/state/session'
import {useLoggedOutViewControls} from '#/state/shell/logged-out'
import {useShellLayout} from '#/state/shell/shell-layout'
import {useCloseAllActiveElements} from '#/state/util'
import {Button} from '#/view/com/util/forms/Button'
import {Text} from '#/view/com/util/text/Text'
import {UserAvatar} from '#/view/com/util/UserAvatar'
import {Logo} from '#/view/icons/Logo'
import {Logotype} from '#/view/icons/Logotype'
import {atoms as a} from '#/alf'
import {Button, ButtonText} from '#/components/Button'
import {useDialogControl} from '#/components/Dialog'
import {SwitchAccountDialog} from '#/components/dialogs/SwitchAccount'
import {
Expand Down Expand Up @@ -299,25 +298,26 @@ export function BottomBar({navigation}: BottomTabBarProps) {
</View>
</View>

<View
style={{flexDirection: 'row', alignItems: 'center', gap: 4}}>
<View style={[a.flex_row, a.flex_wrap, a.gap_sm]}>
<Button
onPress={showCreateAccount}
accessibilityHint={_(msg`Sign up`)}
accessibilityLabel={_(msg`Sign up`)}>
<Text type="md" style={[{color: 'white'}, s.bold]}>
<Trans>Sign up</Trans>
</Text>
label={_(msg`Create account`)}
size="small"
variant="solid"
color="primary">
<ButtonText>
<Trans>Create account</Trans>
</ButtonText>
</Button>

<Button
type="default"
onPress={showSignIn}
accessibilityHint={_(msg`Sign in`)}
accessibilityLabel={_(msg`Sign in`)}>
<Text type="md" style={[pal.text, s.bold]}>
label={_(msg`Sign in`)}
size="small"
variant="solid"
color="secondary">
<ButtonText>
<Trans>Sign in</Trans>
</Text>
</ButtonText>
</Button>
</View>
</View>
Expand Down
Loading

0 comments on commit a0393fc

Please sign in to comment.