Add analytics to track when an installation is created from Github #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
requested changes
Mar 13, 2018
There was a problem hiding this comment.
I'm sorry we had a misunderstanding here, but while the tracking is correct, it would preferable if it were to happen as, the end of the transaction that handles the installation_created event.
That means, in the Sync module, when you have the outcome of Repo.transaction(multi).
That would ensure we do not track at a point where the process might still fail and makes the behavior as explicit and clear as it can be.
|
cool will handle this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
In this PR We are tracking when installations are created from GitHub, This enables us to track installations that don't begin with the Code Corps website as an entry point. At the moment this is just tracking the installation however later we should add tracking for the event that this user creates an account on the website
Make sure any changes to code include changes to documentation.
References
Fixes #1038
Progress on: #1105