Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #17867: [bug] b2RigidBody2D was not removed from b2PhysicsWorld _animatedBodies container if its type was changed. #17873

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

dumganhar
Copy link
Contributor

Re: #17867

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Nov 18, 2024

⚠️ Package size ⤴ 304 bytes, old: 5375852, new: 5376156

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -45987,9 +45987,9 @@
         onFocusInEditor(): void;
         onLostFocusInEditor(): void;
         __preload(): void;
         protected _flushAssembler(): void;
-        protected lateUpdate(dt: any): void;
+        protected lateUpdate(dt: number): void;
         /**
          * @en Add a particle to the emitter.
          * @zh 添加一个粒子到发射器中。
          * @return {Boolean}

@dumganhar dumganhar merged commit 8f43dc7 into cocos:v3.8.5 Nov 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants