Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix camera id #17857

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix camera id #17857

merged 1 commit into from
Nov 18, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Nov 14, 2024

Re: #17861

Fix camera leak in custom pipeline. However, the resource leak might not have been fixed.

I suggest trying Builtin pipeline which will keep improving in the future releases.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

⚠️ Package size ⤴ 26 bytes, old: 5376730, new: 5376756

Interface Check Report

This pull request does not change any public interfaces !

@@ -57,6 +57,8 @@ constexpr ccstd::array<ccstd::array<float, 4>, 4> PRE_TRANSFORMS = {{
{{0, -1, 1, 0}} // SurfaceTransform.ROTATE_270
}};

std::atomic<uint32_t> sCameraId{0};
Copy link
Contributor

@dumganhar dumganhar Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be defined as a atomic variable?
I think Camera could not be created in difference thead.

@minggo minggo merged commit 8ffae0e into cocos:v3.8.5 Nov 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants