Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine rich text and other i18n #17802

Merged
merged 3 commits into from
Nov 4, 2024
Merged

refine rich text and other i18n #17802

merged 3 commits into from
Nov 4, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Nov 4, 2024

Re: #

Changelog

  • refine rich text and other i18n

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Nov 4, 2024

✅ Package size is not changed

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -2093,9 +2093,9 @@
         get font(): TTFFont | null;
         set font(value: TTFFont | null);
         /**
          * @en
-         * Whether use system font name or not.
+         * Whether to use system font name or not.
          *
          * @zh
          * 是否使用系统字体。
          */

@@ -23,7 +23,18 @@
THE SOFTWARE.
*/

import { ccclass, executeInEditMode, executionOrder, help, menu, tooltip, multiline, type, displayOrder, serializable } from 'cc.decorator';
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看引擎都是单行引用,这边需要也改一下

@wuzhiming wuzhiming requested a review from minggo November 4, 2024 03:38
@@ -162,7 +162,6 @@ export class RichText extends Component {
* 富文本显示的文本内容。
*/
@multiline
@tooltip('i18n:richtext.string')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use automatic addition of tooltip

code: ./app/builtin/scene/source/script/export/dump/encode.ts

image

@@ -168,7 +168,6 @@ export class UIRenderer extends Renderer {
*/
@type(Material)
@displayOrder(0)
@displayName('CustomMaterial')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle with a custom approach to adding i18n

code: ./app/builtin/scene/source/script/export/dump/encode.ts

image

editor/i18n/zh/assets.js Outdated Show resolved Hide resolved
@knoxHuang
Copy link
Contributor Author

https://github.com/cocos/3d-tasks/issues/18563

the ui performance of the synchronous cache mode should remain consistent with the label.

@minggo minggo merged commit 43f16f1 into cocos:v3.8.5 Nov 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants