Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.5] cclegacy.xxx invocations should be converted to relevant type which will help refactoring and error reporting. #17753

Merged

Conversation

dumganhar
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

…e which will help refactoring and error reporting.
@dumganhar dumganhar requested a review from minggo October 21, 2024 08:32
if (err) {
error(err.message, err.stack);
} else if (sceneAsset.scene) {
const scene = sceneAsset.scene;
scene._id = sceneAsset._uuid;
scene.id = sceneAsset._uuid;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_id 是 protected property, use id setter instead.

Copy link

github-actions bot commented Oct 21, 2024

👍 Package size ⤵ -203 bytes, old: 5446634, new: 5446431

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -23776,9 +23776,9 @@
         csmLayers: __private._cocos_rendering_shadow_csm_layers__CSMLayers;
         octree: renderer.scene.Octree;
         skin: renderer.scene.Skin;
         postSettings: renderer.scene.PostSettings;
-        lightProbes: any;
+        lightProbes: LightProbes;
         /**
          * @en The list for valid punctual Lights, only available after the scene culling of the current frame.
          * @zh 场景中精确的有效光源,仅在当前帧的场景剔除完成后有效。
          */

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

@minggo minggo merged commit e77c0be into cocos:v3.8.5 Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants