Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.5] Fix a compatibility issue after merging inline-enum PR #17724

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Oct 16, 2024

Re: #17703

#17715

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo October 16, 2024 03:30
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

github-actions bot commented Oct 16, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -37140,8 +37140,9 @@
              * @zh 声音相关的事件。
              */
             Sound = 1
         }
+        export const EventType: typeof DragonBonesEventType;
         /**
          * @en Animation fade out mode.
          * @zh 动画淡出模式。
          */
@@ -46862,8 +46863,9 @@
     }
     export enum PhysicsGroup2D {
         DEFAULT = 1
     }
+    export const PhysicsGroup: typeof PhysicsGroup2D;
     /**
      * @en Enum for ERaycast2DType.
      * @zh 射线检测类型。
      * @enum ERaycast2DType.
@@ -52755,8 +52757,10 @@
              * @zh 私有缓存模式。
              */
             PRIVATE_CACHE = 2
         }
+        export const AnimationCacheMode: typeof SpineAnimationCacheMode;
+        export const DefaultAnimsEnum: typeof __private._cocos_spine_skeleton__SpineDefaultAnimsEnum;
         export interface TempColor {
             r: number;
             g: number;
             b: number;
@@ -69440,8 +69444,14 @@
         }
         /**
          * @engineInternal
          */
+        export enum _cocos_spine_skeleton__SpineDefaultAnimsEnum {
+            '<None>' = 0
+        }
+        /**
+         * @engineInternal
+         */
         export interface _cocos_spine_skeleton__SkeletonDrawData {
             material: Material | null;
             texture: Texture2D | null;
             indexOffset: number;

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL BuildTimeConstantsTest
ios PASS PASS FAIL BuildTimeConstantsTest
mac PASS PASS FAIL BuildTimeConstantsTest

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL BuildTimeConstantsTest
android PASS PASS FAIL BuildTimeConstantsTest
wechatgame PASS PASS FAIL BuildTimeConstantsTest

@dumganhar dumganhar changed the title [v3.8.5] Fix a compatibility issue after merge inline-enum PR [v3.8.5] Fix a compatibility issue after merging inline-enum PR Oct 16, 2024
@dumganhar dumganhar merged commit 495e4c6 into cocos:v3.8.5 Oct 16, 2024
12 checks passed
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL terrain
ios PASS PASS PASS
mac PASS PASS FAIL dynamic-tiled-map,Hexa,object-group-image,puzzle,shield-node

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant