Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: preloadScene would not return the actual data on the onComplete callback #17624

Closed
wants to merge 1 commit into from

Conversation

MrcSnm
Copy link

@MrcSnm MrcSnm commented Sep 10, 2024

Changelog

preloadScene would not return the actual data on the onComplete callback, this caused issues on the following code.

director.preloadScene("scene", (err, scene) =>
{ 
      //Always true since no scene is being sent
      if(!scene) throw err;
});

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@MrcSnm MrcSnm changed the title Bugfix: preloadScene would not return the actual data on the onComple… Bugfix: preloadScene would not return the actual data on the onComplete callback Sep 10, 2024
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@MrcSnm
Copy link
Author

MrcSnm commented Sep 10, 2024

Will do a better PR

@MrcSnm MrcSnm closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant