Fix the JNI error 'global reference table overflow' caused by receiving a large number of WebSocket messages in the background #17609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a large number of WebSocket messages in the background
bofeng-song
changed the title
Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
reviewed
Sep 6, 2024
| @@ -372,7 +360,7 @@ JNI_PATH(nativeOnStringMessage)(JNIEnv * /*env*/, | |||
| jlong handler) { | |||
| auto *wsOkHttp3 = HANDLE_TO_WS_OKHTTP3(handler); // NOLINT(performance-no-int-to-ptr) | |||
| std::string msgStr = JniHelper::jstring2string(msg); | |||
| RUN_IN_GAMETHREAD(wsOkHttp3->onStringMessage(msgStr)); | |||
| wsOkHttp3->onStringMessage(msgStr); | |||
There was a problem hiding this comment.
Why change it?
The Java side has ensured that nativeOnStringMessage runs on the game thread.
There was a problem hiding this comment.
I see. But i don't know why need to do synchronization in java instead in c++?
There was a problem hiding this comment.
While CocosActivity run on background, the old logic will create jni's global object. And the number of global object may exeed system's limit.
There was a problem hiding this comment.
The current implementation also use jni to invoke java codes. Why it doesn't have the problem?
There was a problem hiding this comment.
The global object is created during the nativeOnBinaryMessage call.
dumganhar
approved these changes
Sep 6, 2024
minggo
approved these changes
Sep 6, 2024
zhitaocai
pushed a commit
to zhitaocai/cocos-engine
that referenced
this pull request
Oct 18, 2024
…ng a large number of WebSocket messages in the background (cocos#17609)
AILHC
pushed a commit
to AILHC/cocos-engine
that referenced
this pull request
Oct 19, 2024
…ng a large number of WebSocket messages in the background (cocos#17609) (cherry picked from commit 8f83193)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
#17552
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: