Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom-pipeline-post-process enable failures #17601

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Sep 4, 2024

Re: #

Changelog

  • Fix custom-pipeline-post-process enable failures

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request addresses issues with enabling the custom-pipeline-post-process feature in the Cocos Engine. Here's a summary of the key changes and their implications:

  • Added 'custom-pipeline-post-process' feature in editor/engine-features/render-config.json
  • The feature is disabled by default and hidden from the UI
  • Implemented in cocos/rendering/post-process/post-process-builder.ts

Key points:

  • PostProcessBuilder class in post-process-builder.ts handles the rendering pipeline for post-processing effects
  • The class initializes various passes including shadow, forward, transparency, and post-processing effects
  • cc.config.json defines the 'custom-pipeline-post-process' module and its dependencies

This change allows for better integration and management of custom post-processing effects within the Cocos Engine, potentially fixing issues related to enabling these custom pipelines.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

github-actions bot commented Sep 4, 2024

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e merged commit 93f859f into cocos:v3.8.4 Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants