fix iOS 14 performance issue

cocos · Sep 18, 2024 · 722540e · 722540e
1 parent 9b82eef
commit 722540e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/cocos/gfx/webgl/webgl-commands.ts b/cocos/gfx/webgl/webgl-commands.ts
@@ -831,6 +831,10 @@ export function WebGLCmdFuncUpdateBuffer (
         }
 
         if ((gpuBuffer.memUsage & MemoryUsageBit.HOST) && offset === 0 && size === buff.byteLength) {
+            // Fix performance issue on iOS.
+            // TODO(zhouzhenglong): glBufferSubData is faster than glBufferData in most cases.
+            // We should use multiple buffers to avoid stall (cpu write conflicts with gpu read).
+            // Before that, we will use glBufferData instead of glBufferSubData.
             gl.bufferData(gpuBuffer.glTarget, buff, gl.DYNAMIC_DRAW);
         } else if (size === buff.byteLength) {
             gl.bufferSubData(gpuBuffer.glTarget, offset, buff);

diff --git a/cocos/gfx/webgl2/webgl2-commands.ts b/cocos/gfx/webgl2/webgl2-commands.ts
@@ -1002,6 +1002,10 @@ export function WebGL2CmdFuncUpdateBuffer (
             }
 
             if ((gpuBuffer.memUsage & MemoryUsageBit.HOST) && offset === 0 && size === buff.byteLength) {
+                // Fix performance issue on iOS.
+                // TODO(zhouzhenglong): glBufferSubData is faster than glBufferData in most cases.
+                // We should use multiple buffers to avoid stall (cpu write conflicts with gpu read).
+                // Before that, we will use glBufferData instead of glBufferSubData.
                 gl.bufferData(gpuBuffer.glTarget, buff, gl.DYNAMIC_DRAW);
             } else if (size === buff.byteLength) {
                 gl.bufferSubData(gpuBuffer.glTarget, offset, buff);
@@ -1025,6 +1029,10 @@ export function WebGL2CmdFuncUpdateBuffer (
             }
 
             if ((gpuBuffer.memUsage & MemoryUsageBit.HOST) && offset === 0 && size === buff.byteLength) {
+                // Fix performance issue on iOS.
+                // TODO(zhouzhenglong): glBufferSubData is faster than glBufferData in most cases.
+                // We should use multiple buffers to avoid stall (cpu write conflicts with gpu read).
+                // Before that, we will use glBufferData instead of glBufferSubData.
                 gl.bufferData(gpuBuffer.glTarget, buff, gl.DYNAMIC_DRAW);
             } else if (size === buff.byteLength) {
                 gl.bufferSubData(gpuBuffer.glTarget, offset, buff);
@@ -1040,6 +1048,10 @@ export function WebGL2CmdFuncUpdateBuffer (
             }
 
             if ((gpuBuffer.memUsage & MemoryUsageBit.HOST) && offset === 0 && size === buff.byteLength) {
+                // Fix performance issue on iOS.
+                // TODO(zhouzhenglong): glBufferSubData is faster than glBufferData in most cases.
+                // We should use multiple buffers to avoid stall (cpu write conflicts with gpu read).
+                // Before that, we will use glBufferData instead of glBufferSubData.
                 gl.bufferData(gpuBuffer.glTarget, buff, gl.DYNAMIC_DRAW);
             } else if (size === buff.byteLength) {
                 gl.bufferSubData(gpuBuffer.glTarget, offset, buff);