Skip to content

2.1 Team conventions

Dmitry edited this page Feb 22, 2018 · 2 revisions

Unit tests

  • Every controller has to be tested, as is or through endpoint
  • Convention for unit-test function name is "testThat..." (example: testThatSomethingDoesSomething)

Sourcery Templating

  • All models are generated with Sourcery
  • "allTests" list in XCTestCase for Linux is generated with Sourcery

Approving Pull Requests

  • Wait for PR review - 2 days. If more, admin have right push the merge button.

Github card board

  • In case when an issue is reason to PR, don't move issue to in-review column. Move to done column after merge.
Clone this wiki locally