Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hosts and secretName cannot be updated #921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: hosts and secretName cannot be updated #921

wants to merge 1 commit into from

Conversation

hoyhbx
Copy link

@hoyhbx hoyhbx commented Jun 20, 2022

fix #920

We fixed it by assigning values from the CR to Hosts and SecretName in the ingress resource object in the function BuildV1Ingress.

Checklist

  • I have added these changes to the changelog (or it's not applicable).

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@unw9527 unw9527 mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Updating the field spec.ingress.sql.tls.secretName is not reflected in the sql ingress object
2 participants
@hoyhbx @cockroach-teamcity