testmap: Enable fedora-39 for cockpit, disable fedora-37 #5171
Conversation
martinpitt
force-pushed
the
cockpit-f39
branch
from
2762023 to
98eab0d
Compare
martinpitt
changed the title
|
A large number of failures are due to missing netcat. Plus, a few naughties to copy. |
martinpitt
force-pushed
the
cockpit-f39
branch
from
98eab0d to
e518ac3
Compare
martinpitt
force-pushed
the
cockpit-f39
branch
from
e518ac3 to
d02ef43
Compare
|
OK, most of that works. There's three remaining storage failures which look a bit dubious to me, and I second-guess the claim that this is really known issue #5090. Perhaps testPoolResize is, but testResizeNTFS most likely isn't -- it seems fedora 39 can't mount "ntfs" type any more. I have a faint memory of lwn.net mentioning this, that ntfs got dropped from the kernel; that might be related. The pattern for 5090 is unfortunately very imprecise and catches too many unrelated errors. @mvollmer can you please have a closer look a these two? Thanks! |
|
Ah, one more, this is also fallout from the FIPS breakage. I'll update the naughty. |
martinpitt
force-pushed
the
cockpit-f39
branch
from
d02ef43 to
7ea001c
Compare
|
TestStorageStratis.testPoolResize does indeed look like #5090, but not TestStorageResize.testResizeNtfs. That seems to be missing support for NTFS in the kernel. |
|
I suppose I remembered https://lwn.net/Articles/866112/#ntfs . So that may indeed be an intended change. |
|
testRootReboot gets stuck during shutdown: It's not clear from this what happens, so I applied --- test/common/storagelib.py
+++ test/common/storagelib.py
@@ -20,7 +20,7 @@ import os.path
import re
import textwrap
-from testlib import Error, MachineCase, wait
+from testlib import Error, MachineCase, sit, wait
def from_udisks_ascii(codepoints):
@@ -633,7 +633,10 @@ grub2-install {dev}
grubby --update-kernel=ALL --args="root=UUID=$uuid rootflags=defaults rd.luks.uuid=$luks_uuid rd.lvm.lv=root/root"
! test -f /etc/kernel/cmdline || cp /etc/kernel/cmdline /new-root/etc/kernel/cmdline
""", timeout=300)
- m.spawn("dd if=/dev/zero of=/dev/vda bs=1M count=100; reboot", "reboot", check=False)
+ m.execute("dd if=/dev/zero of=/dev/vda bs=1M count=100")
+ m.execute("systemctl start debug-shell")
+ sit()
+ m.spawn("sleep 5; reboot", "reboot", check=False)
m.wait_reboot(300)
self.assertEqual(m.execute("findmnt -n -o SOURCE /").strip(), "/dev/mapper/root-root")then attach virt-viewer, switch to VT 11 (the debug shell), and continue the test. Indeed Curiously, /boot/efi is still mounted in /proc/self/mounts, but Curiously/helpfully, this weird state already happens during the sit(), without the rebooting. So that whole /boot shiftery somehow destroys or overlays the /boot/efi mount. But what does work is to run |
|
I sent a cockpit PR to fix testRootReboot, blocking on that. I also copied the testPoolResize half of the 5090 naughty. So the only remaining one is testResizeNtfs, I updated the todo list. |
martinpitt
force-pushed
the
cockpit-f39
branch
from
7ea001c to
5cd901c
Compare
|
testResizeNtfs is much simpler: While fedora-38 has
which is the other half of #5090. I'll add that remaining naughty here. I'll send a bots PR to add ntfs-3g to the image, blocking on that. That should cover everything. |
martinpitt
force-pushed
the
cockpit-f39
branch
from
5cd901c to
ff8a6c6
Compare
Downstream report: https://bugzilla.redhat.com/show_bug.cgi?id=2235578 Known issue cockpit-project#5173
This also produces systemd-coredump traces. Add a minimal match to ensure that the login page really fails due to the crash, not due to some other reason. This applies to both testCryptoPolicies and testInconsistentCryptoPolicy, so use a slightly funny fnmatch to catch both. Downstream report: https://bugzilla.redhat.com/show_bug.cgi?id=2235589 Known issue cockpit-project#5174
martinpitt
force-pushed
the
cockpit-f39
branch
from
ff8a6c6 to
e468c31
Compare
Commit 47bc4c5 dropped F37 from releasing, and cockpit-project/bots#5171 dropped it from CI.
Commit 47bc4c5 dropped F37 from releasing, and cockpit-project/bots#5171 dropped it from CI.
I initially thought that we need to do the usual "adjust test special cases", but it seems we replaced them all with globs now 💪 So let's see how far they get!
crashkernel=1G-4G:192M,4G-64G:256M,64G-:512Mby default, so it runs; fixed by test: Invert "no crashkernel= by default" expectation in kdump test; fix testCPUSecurityMitigationsEnable on fedora-39 cockpit#19254TestStorageNBDE.testRootReboot: test: Don't encrypt/move the EFI partition in encrypt_root cockpit#19256ntfsfile system any more: PR images: Explicitly install ntfs-3g on Fedora images #5178Trigger command for iterating:
./tests-trigger 5171 fedora-39/{networking,storage,expensive,other}@cockpit-project/cockpit