use / as base url instead of host addr in serve cmd #1169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Tunneling! For example GitHub Codespaces will tunnel your port 1234 on your codespace's localhost to https://sometunnel-1234.githubcodespaces.example.org/. if you try to get
http://localhost:1234/style.css
then it fails since its not on localhost; its on a completely separate domainex:
This pr (hopefully) would fix that by turning the HTML from this:
into this which works across localhost and tunnels