Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1 tracking update #47067

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

L1 tracking update #47067

wants to merge 3 commits into from
+13,201 −10,167

Conversation

tschuh
Copy link
Contributor

@tschuh tschuh commented Jan 9, 2025

This PR updates mainly the modules

  • L1Trigger/TrackFindingTracklet
  • L1Trigger/TrackFindingTMTT
  • L1Trigger/TrackTrigger
  • L1Trigger/TrackerDTC
  • L1Trigger/TrackerTFP
  • DataFormats/L1TrackTrigger
  • SimTracker/TrackTriggerAssociation

in order to sync s/w emulation of L1 tracking with current f/w. Some name changes have also been propagated to additional modules.

The code changes of this PR did pass review of L1 tracking community checking for L1 tracking performance, code formats, etc.

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Jan 9, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43234

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43235

@tschuh tschuh force-pushed the L1TK-PR-14_2_0_pre4 branch from 94ae2d7 to e2dc5ef Compare January 9, 2025 15:19
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43238

@tschuh
squash before rebase for PR to central cmssw.
17aee38 
ci workflow deleted from pr.

data folder deleted.
@tschuh tschuh force-pushed the L1TK-PR-14_2_0_pre4 branch from e2dc5ef to a5f36b2 Compare January 9, 2025 15:27
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43240

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

A new Pull Request was created by @tschuh for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DataFormats/L1TrackTrigger (upgrade, l1)
  • DataFormats/WrappedStdDictionaries (core)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
  • L1Trigger/TrackFindingTMTT (l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • L1Trigger/TrackTrigger (upgrade, l1)
  • L1Trigger/TrackerDTC (upgrade, l1)
  • L1Trigger/TrackerTFP (l1)
  • SimTracker/TrackTriggerAssociation (simulation, l1)

@Dr15Jones, @Moanwar, @aloeliger, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @rappoccio, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @erikbutz, @fabiocos, @felicepantaleo, @makortel, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @skinnari, @slomeo, @sviret, @threus, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Jan 9, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

+1

Size: This PR adds an extra 928KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7f383/43702/summary.html
COMMIT: a5f36b2
CMSSW: CMSSW_15_0_X_2025-01-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47067/43702/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7f383/43702/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7f383/43702/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 129 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 517
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3818181
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.8560000000000004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): -0.012 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Warnings
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 3 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changes-dataformats code-checks-approved core-pending l1-pending operations-approved orp-pending pending-signatures simulation-pending tests-approved trk upgrade-pending
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@tschuh @cmsbuild @makortel