Remove ReadBase as unused

[makortel]

PR description:

This code was calling putenv() (see #46002 (comment)), but turned out to be unused, so this PR proposes to remove the code.

Resolves cms-sw/framework-team#1142

PR validation:

Code compiles

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47039/43164

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47039/43164/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47039/43164/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47039/43166

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• CondTools/DQM (db, dqm)

@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta, @rseidita can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a1bfc/43622/summary.html
COMMIT: 0fca86c
CMSSW: CMSSW_15_0_X_2025-01-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47039/43622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3818730
• DQMHistoTests: Total failures: 490
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3818220
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

• Indeed, the code removed here was unused, also commented out in the calling code

[makortel]

@cms-sw/dqm-l2 Could you review and sign? Thanks!

[antoniovagnerini]

+1

• spurious differences from HGCal DQM test (see Non reproducibility in HGCal DQM #46416 - recently solved)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)