-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including Geometry/HGCalMapping in categories_map #2153
Including Geometry/HGCalMapping in categories_map #2153
Conversation
A new Pull Request was created by @kerstinlovisa (Lovisa Rygaard) for branch master. @iarspider, @smuzaffar, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
assign geometry,upgrades |
New categories assigned: geometry @Dr15Jones,@civanch,@bsunanda,@makortel,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@kerstinlovisa @ALL i would suggest to add to |
Pull request #2153 was updated. |
assign geometry, upgrades |
categories_map.py
Outdated
@@ -1632,6 +1633,7 @@ | |||
"upgrade": [ | |||
"CalibTracker/SiPhase2TrackerESProducers", | |||
"CondFormats/HGCalObjects", | |||
"Geometry/HGCalMapping", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this downwards to keep the alphabetic order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it down so it should be in alphabetic order now
Pull request #2153 was updated. |
+externals any objections @cms-sw/geometry-l2 @cms-sw/upgrade-l2 on adding |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Including Geometry/HGCalMapping in categories_map.py under "geometry"