Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including Geometry/HGCalMapping in categories_map #2153

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

kerstinlovisa
Copy link

Including Geometry/HGCalMapping in categories_map.py under "geometry"

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kerstinlovisa (Lovisa Rygaard) for branch master.

@iarspider, @smuzaffar, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 19, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor

iarspider commented Jan 23, 2024

assign geometry,upgrades

@cmsbuild
Copy link
Contributor

New categories assigned: geometry

@Dr15Jones,@civanch,@bsunanda,@makortel,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

@pfs
Copy link

pfs commented Jan 23, 2024

@kerstinlovisa @ALL i would suggest to add to upgrades as well for the moment

@cmsbuild
Copy link
Contributor

Pull request #2153 was updated.

@iarspider
Copy link
Contributor

assign geometry, upgrades

@kerstinlovisa
Copy link
Author

@pfs @ALL HGCalMapping also added to upgrades category now

@@ -1632,6 +1633,7 @@
"upgrade": [
"CalibTracker/SiPhase2TrackerESProducers",
"CondFormats/HGCalObjects",
"Geometry/HGCalMapping",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this downwards to keep the alphabetic order.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it down so it should be in alphabetic order now

@cmsbuild
Copy link
Contributor

Pull request #2153 was updated.

@smuzaffar
Copy link
Contributor

smuzaffar commented Jan 23, 2024

+externals

any objections @cms-sw/geometry-l2 @cms-sw/upgrade-l2 on adding Geometry/HGCalMapping under your control?

@civanch
Copy link
Contributor

civanch commented Jan 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit e21d1a2 into cms-sw:master Jan 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants