-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout parameters passed to Elasticsearch object #54
base: master
Are you sure you want to change the base?
Conversation
Create timeout and retry on timeout parameters in the handler constuructor. Parameters passed to Elasticsearch object, and used while performing bulk_send().
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 83% 83.43% +0.43%
==========================================
Files 2 2
Lines 153 157 +4
Branches 20 20
==========================================
+ Hits 127 131 +4
Misses 22 22
Partials 4 4
Continue to review full report at Codecov.
|
@cmanaha I think this is a very useful feature and I would like to have this too. Can I do anything to support merging this? |
@cmanaha Ping |
@KonstantinSchubert ; Apologies for about being completely absent. Konstantin, I've added you to the collaborators of the project. I have not managed to allocate and commit time for keeping this project up to date for the last few months, and the project indeed still need some love (this pull request is an example, + eventually upgrade to 6, and others). I have to disclose also I joined AWS about 4 months ago. I'd like at some point to spend time to get some of the other integrations people have been asking (role, auth certificates, and stuff like that), but I'll not be able to commit the time for the next 3 months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks a lot for the contribution.
It's very useful, I was looking for this feature recently! 👍
I have made some adjustments to the doc strings to bring them more in line with the existing ones.
If you agree then you can apply the suggested changes.
@kusha Paging. |
Co-Authored-By: kusha <[email protected]>
@KonstantinSchubert I've applied your suggestions. Feel free to merge. |
Create timeout and retry on timeout parameters in the handler constuructor.
Parameters passed to Elasticsearch object, and used while performing bulk_send().