Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take swagger-ui host from custom.conf #438

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

bingzhang
Copy link
Contributor

@bingzhang bingzhang commented Dec 1, 2023

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bingzhang bingzhang requested a review from lmarini December 1, 2023 16:07
@bingzhang bingzhang self-assigned this Dec 1, 2023
@bingzhang
Copy link
Contributor Author

I tested the custom.conf fix in my local. it works.

I did not test the docker env fix. and I will test it later.

@bingzhang
Copy link
Contributor Author

I tested the custom.conf fix in my local. it works.

I did not test the docker env fix. and I will test it later.

I did the docker test at UIUC vm. with the ENV setting SWAGGER_UI_HOST=YourSwaggerUIHost, it will use the swagger ui to show the swagger doc. Otherwise, it will use the default https://clowder.ncsa.illinois.edu/swagger endpoint to show the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant