Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: union missing extra #232

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

ztjryg4
Copy link
Contributor

@ztjryg4 ztjryg4 commented Sep 18, 2024

Description

Fixed the issue where Union, Exception, and their Field did not have Extra information.

Motivation and Context

In the thrift_reflection/descriptor_register.go, when registerGlobalUUID for all structures (Struct, Union, and Exception), only Struct was traversed. As a result, Union, Exception, and their Field did not have Extra added, which caused methods like .IsStruct() for struct fields under Union to return unexpected results.

@ztjryg4 ztjryg4 requested review from a team as code owners September 18, 2024 12:31
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

Change-Id: I2fc46b12ea753978876289f7c39d5e4354e447fb
@ztjryg4 ztjryg4 force-pushed the fix/union-missing-extra branch from e16f21d to 37a0afb Compare September 18, 2024 12:38
@HeyJavaBean
Copy link
Member

thanks for your pr~

@HeyJavaBean HeyJavaBean merged commit 2bac1d3 into cloudwego:main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants