feat: add yaml-config support for trimmer #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tksky1
force-pushed
the
feat/trimmer-yaml-config
branch
from
21c765c to
9cf7b78
Compare
HeyJavaBean
changed the title
…eat/trimmer-yaml-config
HeyJavaBean
reviewed
Oct 24, 2023
FGYFFFF
reviewed
Oct 24, 2023
HeyJavaBean
changed the title
HeyJavaBean
previously approved these changes
Oct 24, 2023
tksky1
dismissed
HeyJavaBean’s stale review
The merge-base changed after approval.
HeyJavaBean
previously approved these changes
Oct 24, 2023
tksky1
dismissed
HeyJavaBean’s stale review
The merge-base changed after approval.
HeyJavaBean
previously approved these changes
Oct 24, 2023
tksky1
dismissed
HeyJavaBean’s stale review
The merge-base changed after approval.
HeyJavaBean
approved these changes
Oct 24, 2023
3 tasks
HeyJavaBean
added a commit
that referenced
this pull request
Feb 21, 2024
Co-authored-by: Li2CO3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add yaml-config support for -m and -p option for trimmer. When using thriftgo/kitex to call trimmer as a feature, these options can also be toggled by the yaml-config in the same directory of target IDL file.
For example:
By adding configurations below to trim_config.yaml, you'll able to toggle these settings whenever you trim test.thrift:
this works the same way as input params.
Motivation and Context
When using trimmer as a feature by thriftgo/kitex, using methods-specified trimming or disable preservation was impossible. By adding yaml-config support, these options can also be set through yaml files.