Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(codegen): use ::std::default::Default in struct's codegen #295

Merged
merged 1 commit into from
Jan 3, 2025
Merged

chore(codegen): use ::std::default::Default in struct's codegen #295

merged 1 commit into from
Jan 3, 2025
+10 −10

Conversation

flaneur2020
Copy link
Contributor

@flaneur2020 flaneur2020 commented Jan 3, 2025 •
edited
Loading

Motivation

this pr is a follow up of this thread from #294

the codegen of struct still generates Default without absolute path, it might risks to conflict with user defined struct named as Default.

Solution

this pr changed the Default as absolute path as well.

@flaneur2020 flaneur2020 marked this pull request as ready for review January 3, 2025 04:21
@flaneur2020 flaneur2020 requested review from a team as code owners January 3, 2025 04:21
Millione
Millione approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Millione Millione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Millione Millione merged commit 34df6a0 into cloudwego:main Jan 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Millione Millione Millione approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaneur2020 @Millione