Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ttstream): pingpong method refers to server interface defined in Kitex generation code when streamx is enabled and there are other streaming methods #1642

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(ttstream): 当开启 StreamX 并且存在 Streaming 方法时,Ping-Pong 方法引用 Kitex 生成代码中的服务接口定义

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
When StreamX is enabled, if both Streaming method and Ping-Pong method exist in the service, the Streaming method references the Service Interface Definition in the Kitex generated code, while the Ping-Pong method references the Service Interface Definition in the thriftgo generated code, which is not consistent.
After fixing, the Ping-Pong method also references the service interface definition in the Kitex generated code.
Translated with www.DeepL.com/Translator (free version)
zh(optional):
当开启 StreamX 时,若服务中同时存在 Streaming 方法和 Ping-Pong 方法,Streaming 方法会引用 Kitex 生成代码中的服务接口定义,而 Ping-Pong 方法会引用 thriftgo 生成代码中的服务接口定义,两者并不统一。
修复后,Ping-Pong 方法也会引用 Kitex 生成代码中的服务接口定义。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

…ration code when streamx is enabled and there are other streaming methods
@DMwangnima DMwangnima requested review from a team as code owners December 17, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant