Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz):Append content cannot use template's function #999

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(hz):Append content cannot use template's function #999

merged 1 commit into from
Nov 17, 2023

Conversation

ypo2478
Copy link
Contributor

@ypo2478 ypo2478 commented Nov 15, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

追加内容不能使用模板函数

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):自定义 package 模板append_content_tpl无法使用模板函数

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@ypo2478 ypo2478 requested review from a team as code owners November 15, 2023 15:04
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023

CLA assistant check
All committers have signed the CLA.

@FGYFFFF
Copy link
Contributor

FGYFFFF commented Nov 16, 2023

thanks~ Please sign the CLA

@ypo2478
Copy link
Contributor Author

ypo2478 commented Nov 16, 2023

thanks~ Please sign the CLA

done

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c849a7a) 81.83% compared to head (a7496ff) 81.81%.

❗ Current head a7496ff differs from pull request most recent head bb87430. Consider uploading reports for the commit bb87430 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #999      +/-   ##
===========================================
- Coverage    81.83%   81.81%   -0.03%     
===========================================
  Files           98       98              
  Lines         9962     9962              
===========================================
- Hits          8152     8150       -2     
- Misses        1318     1319       +1     
- Partials       492      493       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jin-gou li-jin-gou merged commit 9c3f0b7 into cloudwego:develop Nov 17, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants