Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): router import error for 'api.service_gen_dir' #1127

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented May 28, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复指定 'api.service_gen_dir' 时的路由 import 错误的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: fix router import error for 'api.service_gen_dir'
zh(optional): 修复指定 'api.service_gen_dir' 时的路由 import 错误的问题
当我们如下定义 IDL 的时候,生成的 handler 路径与 'api.service_gen_dir' 一致;在生成路由的没有去解析这个路径的 import,导致生产的 import 路径有问题

service Hertz2 {
    Resp Method1(1: MultiTypeReq request) (api.get="/a/b/c");
}(

     api.service_gen_dir="/handle2/ss/ss/trt"
 )

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners May 28, 2024 12:15
@FGYFFFF FGYFFFF force-pushed the fix/service_gen_dir_import_err branch from ac7e8e9 to 164973c Compare July 11, 2024 08:26
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (9162dd1) to head (164973c).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1127      +/-   ##
===========================================
+ Coverage    82.75%   82.80%   +0.05%     
===========================================
  Files           98       98              
  Lines        10044    10062      +18     
===========================================
+ Hits          8312     8332      +20     
+ Misses        1241     1240       -1     
+ Partials       491      490       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF merged commit aaf400a into cloudwego:develop Jul 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants