Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: filter invalid char in header #1039

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

welkeyever
Copy link
Member

@welkeyever welkeyever commented Jan 2, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
image

zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@welkeyever welkeyever requested review from a team as code owners January 2, 2024 08:31
@welkeyever welkeyever marked this pull request as draft January 2, 2024 08:31
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1f93aaa) 82.47% compared to head (22226d3) 82.51%.

Files Patch % Lines
pkg/protocol/header.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1039      +/-   ##
===========================================
+ Coverage    82.47%   82.51%   +0.04%     
===========================================
  Files           98       98              
  Lines        10002    10011       +9     
===========================================
+ Hits          8249     8261      +12     
- Misses        1253     1254       +1     
+ Partials       500      496       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@welkeyever welkeyever force-pushed the optimize/filter_invalid_char_in_header branch from d2f2fa6 to 9c59c28 Compare January 2, 2024 11:25
Base automatically changed from optimize/get_rid_of_invalid_headers to develop January 3, 2024 03:15
@welkeyever welkeyever force-pushed the optimize/filter_invalid_char_in_header branch from 731b58b to 0c0bd57 Compare January 3, 2024 07:40
@welkeyever welkeyever changed the title Optimize/filter invalid char in header optimize: filter invalid char in header Jan 3, 2024
@welkeyever welkeyever marked this pull request as ready for review January 3, 2024 08:11
@welkeyever welkeyever force-pushed the optimize/filter_invalid_char_in_header branch from d66bb41 to 22226d3 Compare January 10, 2024 02:55
@welkeyever welkeyever merged commit 119a744 into develop Jan 10, 2024
25 of 26 checks passed
@welkeyever welkeyever deleted the optimize/filter_invalid_char_in_header branch January 10, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants