Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: filter shortConnErr in tracer #1037

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Dec 25, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

  • 在 trace 中过滤 shortConnErr 错误

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@li-jin-gou li-jin-gou requested review from a team as code owners December 25, 2023 15:16
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0619701) 82.52% compared to head (5741078) 82.52%.

Files Patch % Lines
pkg/protocol/http1/server.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1037      +/-   ##
===========================================
- Coverage    82.52%   82.52%   -0.01%     
===========================================
  Files           98       98              
  Lines        10025    10029       +4     
===========================================
+ Hits          8273     8276       +3     
- Misses        1255     1257       +2     
+ Partials       497      496       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jin-gou li-jin-gou changed the title optimize: filter shortConnErr in tracer WIPoptimize: filter shortConnErr in tracer Dec 26, 2023
@li-jin-gou li-jin-gou changed the title WIPoptimize: filter shortConnErr in tracer WIP: optimize: filter shortConnErr in tracer Dec 26, 2023
@li-jin-gou li-jin-gou force-pushed the fix/short_conn_err_trace branch 2 times, most recently from acf0726 to f581345 Compare January 27, 2024 14:41
@li-jin-gou li-jin-gou changed the title WIP: optimize: filter shortConnErr in tracer optimize: filter shortConnErr in tracer Jan 27, 2024
@li-jin-gou li-jin-gou force-pushed the fix/short_conn_err_trace branch from 2a19741 to 5741078 Compare February 3, 2024 10:28
@welkeyever welkeyever merged commit 1f9997c into cloudwego:develop Mar 5, 2024
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants