Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize HandlerName && add setIndex #1031

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

ViolaPioggia
Copy link
Member

@ViolaPioggia ViolaPioggia commented Dec 17, 2023

What type of PR is this?

feat

Check the PR title.

feat: optimize HandlerName && add setIndex

(Optional) Translate the PR title into Chinese.

  • 增加 SetIndex 方法
  • 保证 HandlerName 操作的并发安全

@ViolaPioggia ViolaPioggia requested review from a team as code owners December 17, 2023 06:58
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82f9bfa) 82.55% compared to head (61b0f21) 82.57%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1031      +/-   ##
===========================================
+ Coverage    82.55%   82.57%   +0.01%     
===========================================
  Files           98       98              
  Lines         9974    10002      +28     
===========================================
+ Hits          8234     8259      +25     
- Misses        1244     1246       +2     
- Partials       496      497       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/app/context_test.go Outdated Show resolved Hide resolved
@FGYFFFF
Copy link
Contributor

FGYFFFF commented Dec 19, 2023

请补充下 pr 的描述相关内容

li-jin-gou
li-jin-gou previously approved these changes Dec 19, 2023
Duslia
Duslia previously approved these changes Dec 28, 2023
pkg/app/context.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou dismissed stale reviews from Duslia and themself via 02b7042 January 8, 2024 12:34
pkg/app/context.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou merged commit 1f93aaa into cloudwego:develop Jan 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants