Limit the daily balance that is taken into account when calculating yield #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihoroleksiienko
requested review from
igorsenych-cw and
EvgeniiZaitsevCW
as code owners
EvgeniiZaitsevCW
previously approved these changes
Mar 13, 2024
igorsenych-cw
approved these changes
Mar 14, 2024
igorsenych-cw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A maximum daily balance limit has been added to restrict yield calculation. Maximum daily limit for yield calculation is defined by constant
MAX_DAILY_BALANCE_LIMITKey Highlights
minfor dayDis determined by comparing balances for days fromD - N - 1toDinclusive, whereNis the interval for viewing balances specified in the contract.min > MAX_DAILY_BALANCE_LIMITthanmin = MAX_DAILY_BALANCE_LIMITdailyYield = minBalance * rate, whereRateis the daily yield rate.Current configurations
MAX_DAILY_BALANCE_LIMIT- 200K BRLCFEE_RATE- 0%Test coverage
New functionality was fully covered with tests