-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the possibility to increase and decrease frozen balance #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihoroleksiienko
requested review from
igorsenych-cw and
EvgeniiZaitsevCW
as code owners
August 16, 2024 08:30
Reopened because I accidentally removed the remote branch instead of the local one |
EvgeniiZaitsevCW
approved these changes
Aug 19, 2024
igorsenych-cw
changed the title
Adding the possibility to increase and decrease frozen balance
feat: add the possibility to increase and decrease frozen balance
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
freezeIncrease()
has been created to increase an existing frozen balance by a certain amount.freezeDecrease()
has been created to decrease an existing frozen balance by a certain amount.freeze()
function has been updated to prohibit the ability to use a zero address as account.freeze()
function has been marked asdeprecated
. We are going to remove it in the future.Functions declaration
Functions details
Emitted events
The new functions trigger the existing event
Freeze
:Reverting Conditions
The new functions are reverted (failed) if:
"Pausable: paused"
.blocklister
, with theUnauthorizedBlocklister
error.account
function, with theZeroAddress
error.amount
, with theZeroAmount
error.FreezingNotApproved
error.Test coverage
New functionality was fully covered with tests