Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade security group module #24

Closed
wants to merge 26 commits into from
Closed

Upgrade security group module #24

wants to merge 26 commits into from

Conversation

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode marked this pull request as ready for review July 26, 2022 02:51
@nitrocode nitrocode requested review from a team as code owners July 26, 2022 02:51
@nitrocode nitrocode requested a review from Gowiem July 26, 2022 21:05
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@mergify
Copy link

mergify bot commented Jul 29, 2022

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

@Nuru Nuru added do not merge Do not merge this PR, doing so would cause problems wip Work in Progress: Not ready for final review or merge labels Jul 29, 2022
Comment on lines +89 to +91
source = "git::https://github.com/cloudposse/terraform-aws-security-group?ref=2.0.0-rc1"
# source = "cloudposse/security-group/aws"
# version = "1.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source = "git::https://github.com/cloudposse/terraform-aws-security-group?ref=2.0.0-rc1"
# source = "cloudposse/security-group/aws"
# version = "1.0.1"
source = "cloudposse/security-group/aws"
version = "2.0.0-rc1"

@hans-d hans-d added the stale This PR has gone stale label Mar 8, 2024
@hans-d hans-d closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR, doing so would cause problems stale This PR has gone stale wip Work in Progress: Not ready for final review or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Transfer ID Support endpoint_type of VPC_ENDPOINT
5 participants