Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding tags to the acm resource #26

Closed
wants to merge 2 commits into from
Closed

feat: Adding tags to the acm resource #26

wants to merge 2 commits into from

Conversation

franciscorosati
Copy link

what

Tags will be added to the acm resource

why

Adding tags to the ACM resource helps to manage, track and identify the certificate due to there is no other way to do it

@franciscorosati franciscorosati requested review from a team as code owners November 24, 2023 13:15
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

@franciscorosati Hi, can you update the readme as per the failing check?

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 10, 2024

Thanks @franciscorosati for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-test Needs testing label Mar 10, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 17, 2024
@franciscorosati
Copy link
Author

Closing because was open for several month with a simple change and no action was taken

@franciscorosati franciscorosati deleted the acm-tags branch March 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
needs-test Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscorosati @hans-d