feat(aws_instance): conditional IAM instance profile

[haidargit]

what

This PR enables a conditional iam_instance_profile variable for the ec2 module.

why

This feature request offers users the flexibility to decide whether to associate an IAM instance profile with their instances.

references

• closes feature request Unable to create an instance without any IAM role #180

Kindly review this PR for module improvements. Thank you

[haidargit]

Hi @kevcube , @nitrocode
would you help to review the PR or any other changes that need to be added?

Thank you

[nitrocode]

Did you try setting the instance_profile to an empty string to disable its creation without an additional flag?

[haidargit]

which additional flag do you mean, @nitrocode ?
could you help comment or point to the code/PR?

Thanks 🙌

[joe-niland]

@nitrocode instance_profile == "" signifies that the default instance profile and role should be created, whereas #180 is requesting that it be possible to create an instance without a profile + role.

[haidargit]

Thank you, yes that's what I meant for this feature request. @joe-niland , @nitrocode

[joe-niland]

/terratest

[joe-niland]

Hi @haidargit please have a look at the Terratest failures: https://github.com/cloudposse/actions/actions/runs/7605926145/job/20710921759

[haidargit]

okay @joe-niland, i am checking on it

[haidargit]

i have committed the changes for applying the consistent types for the true and false result expressions to these two outputs

output "role" & output "role_arn"

could you help test again @joe-niland ?
Thanks!

[joe-niland]

/terratest

[joe-niland]

@haidargit all seems fine. I will just make sure @nitrocode is OK with the PR as well before we proceed.

[nitrocode]

I defer to you folks. Thanks for including me. :)

[joe-niland]

Cheers @nitrocode!

Thanks for your contribution @haidargit !

[haidargit]

your welcome @joe-niland, @joe-niland 👍🏻 👍🏻