Merge pull request #220 from zakhenry/feat/optional-disabled

feat(Disabled): Permit root forms to omit the disabled option, defaul…
cloudnc · Jun 23, 2021 · 8d9e3ce · 8d9e3ce
2 parents b3e9ec1 + d1f95c1
commit 8d9e3ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/projects/ngx-sub-form/src/lib/ngx-sub-form.ts b/projects/ngx-sub-form/src/lib/ngx-sub-form.ts
@@ -124,7 +124,7 @@ export function createForm<ControlInterface, FormInterface>(
     ControlInterface,
     FormInterface
   >(options)
-    ? options.disabled$
+    ? options.disabled$ ?? EMPTY
     : componentHooks.setDisabledState$;
 
   const transformedValue$: Observable<FormInterface> = writeValue$.pipe(

diff --git a/projects/ngx-sub-form/src/lib/ngx-sub-form.types.ts b/projects/ngx-sub-form/src/lib/ngx-sub-form.types.ts
@@ -84,9 +84,9 @@ export type NgxRootFormOptions<ControlInterface, FormInterface = ControlInterfac
   ControlInterface,
   FormInterface
 > & {
-  disabled$: Observable<boolean>;
   input$: Observable<ControlInterface | undefined>;
   output$: Subject<ControlInterface>;
+  disabled$?: Observable<boolean>;
   // by default, a root form is considered as an automatic root form
   // if you want to transform it into a manual root form, provide the
   // following observable which trigger a save every time a value is emitted